----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61021/#review182699 -----------------------------------------------------------
security-admin/src/main/webapp/scripts/views/policies/PermissionList.js Lines 195 (patched) <https://reviews.apache.org/r/61021/#comment258680> Probably a much bigger change, but ideally, in the web module, there shouldn't be much any service or kylin specific thing. It would be better to put these kylin roles in the service defs, under for example 'extra options' or some other structure. So next time, when a new service would need a similar functionality, it could reuse the code - and not in a 'copy-paste' sense :) - Zsombor Gegesy On Aug. 8, 2017, 2:08 a.m., Qiang Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61021/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2017, 2:08 a.m.) > > > Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, sam rome, and Velmurugan Periasamy. > > > Bugs: RANGER-1672 > https://issues.apache.org/jira/browse/RANGER-1672 > > > Repository: ranger > > > Description > ------- > > Ranger supports plugin to enable, monitor and manage apache kylin > > > Diffs > ----- > > agents-common/scripts/enable-agent.sh d31a264 > > agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBaseService.java > f1c6b9f > > agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java > 0bc09f6 > > agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java > 58cdd35 > agents-common/src/main/resources/service-defs/ranger-servicedef-kylin.json > PRE-CREATION > plugin-kylin/.gitignore PRE-CREATION > plugin-kylin/conf/ranger-kylin-audit-changes.cfg PRE-CREATION > plugin-kylin/conf/ranger-kylin-audit.xml PRE-CREATION > plugin-kylin/conf/ranger-kylin-security-changes.cfg PRE-CREATION > plugin-kylin/conf/ranger-kylin-security.xml PRE-CREATION > plugin-kylin/conf/ranger-policymgr-ssl-changes.cfg PRE-CREATION > plugin-kylin/conf/ranger-policymgr-ssl.xml PRE-CREATION > plugin-kylin/pom.xml PRE-CREATION > plugin-kylin/scripts/install.properties PRE-CREATION > > plugin-kylin/src/main/java/org/apache/ranger/authorization/kylin/authorizer/RangerKylinAuthorizer.java > PRE-CREATION > > plugin-kylin/src/main/java/org/apache/ranger/services/kylin/RangerServiceKylin.java > PRE-CREATION > > plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinClient.java > PRE-CREATION > > plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinResourceMgr.java > PRE-CREATION > > plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/json/model/KylinCubeResponse.java > PRE-CREATION > > plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/json/model/KylinProjectResponse.java > PRE-CREATION > pom.xml 01005b7 > ranger-kylin-plugin-shim/.gitignore PRE-CREATION > ranger-kylin-plugin-shim/pom.xml PRE-CREATION > > ranger-kylin-plugin-shim/src/main/java/org/apache/ranger/authorization/kylin/authorizer/RangerKylinAuthorizer.java > PRE-CREATION > security-admin/src/main/webapp/scripts/utils/XAEnums.js 164e939 > security-admin/src/main/webapp/scripts/utils/XAUtils.js 1979847 > security-admin/src/main/webapp/scripts/views/policies/PermissionList.js > 067bf3b > src/main/assembly/admin-web.xml cb1aad2 > src/main/assembly/plugin-kylin.xml PRE-CREATION > > > Diff: https://reviews.apache.org/r/61021/diff/2/ > > > Testing > ------- > > Tested > > > Thanks, > > Qiang Zhang > >
