----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61021/#review181339 -----------------------------------------------------------
security-admin/src/main/webapp/scripts/views/policies/PermissionList.js Lines 198 (patched) <https://reviews.apache.org/r/61021/#comment256879> Can we move variable declaration statements to top of function start ? security-admin/src/main/webapp/scripts/views/policies/PermissionList.js Line 208 (original), 213 (patched) <https://reviews.apache.org/r/61021/#comment256880> As per the changes looks like query params `service` and `service name` are only required for populating the users drop-down and also for user rest call in kyline component only. However since this is a common code the params will be added to ALL rest calls made from other components also. Please modify this code to send the params only for kyline component. security-admin/src/main/webapp/scripts/views/policies/PermissionList.js Lines 219 (patched) <https://reviews.apache.org/r/61021/#comment256881> Here as per the changes looks like we are showing specific hard-coded set of roles in the `Select Role` drop-down and which are not loaded using any of rest call. If that is the requirement, can we remove ajax call for `Select Role` drop-down for this component. This can done by simply removing `ajax` option from select2 plugin and setting `tags` attribute to array like tags : [ROLE_ADMIN','ROLE_MODELER','ROLE_ANALYST'] Note : This case is only applicable for Select Role in kyline component. Also can we move roles to enum file by simply specifiying `XAEnums.kylinRole` in XAEnum file? security-admin/src/main/webapp/scripts/views/policies/PermissionList.js Line 235 (original), 245 (patched) <https://reviews.apache.org/r/61021/#comment256882> Rename `notMath` to `noMatch`. security-admin/src/main/webapp/scripts/views/policies/PermissionList.js Lines 265 (patched) <https://reviews.apache.org/r/61021/#comment256883> Can we create util function to check service definition is of kyline or not in `XAUtil.js` file? So that we can reuse it like we use `XAUtils.isTagServiceDef()`. - Nitin Galave On July 21, 2017, 7:40 a.m., Qiang Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61021/ > ----------------------------------------------------------- > > (Updated July 21, 2017, 7:40 a.m.) > > > Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, sam rome, and Velmurugan Periasamy. > > > Bugs: RANGER-1672 > https://issues.apache.org/jira/browse/RANGER-1672 > > > Repository: ranger > > > Description > ------- > > Ranger supports plugin to enable, monitor and manage apache kylin > > > Diffs > ----- > > agents-common/scripts/enable-agent.sh d31a264 > > agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java > 0bc09f6 > > agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java > 58cdd35 > agents-common/src/main/resources/service-defs/ranger-servicedef-kylin.json > PRE-CREATION > plugin-kylin/.gitignore PRE-CREATION > plugin-kylin/conf/ranger-kylin-audit-changes.cfg PRE-CREATION > plugin-kylin/conf/ranger-kylin-audit.xml PRE-CREATION > plugin-kylin/conf/ranger-kylin-security-changes.cfg PRE-CREATION > plugin-kylin/conf/ranger-kylin-security.xml PRE-CREATION > plugin-kylin/conf/ranger-policymgr-ssl-changes.cfg PRE-CREATION > plugin-kylin/conf/ranger-policymgr-ssl.xml PRE-CREATION > plugin-kylin/pom.xml PRE-CREATION > plugin-kylin/scripts/install.properties PRE-CREATION > > plugin-kylin/src/main/java/org/apache/ranger/authorization/kylin/authorizer/RangerKylinAuthorizer.java > PRE-CREATION > > plugin-kylin/src/main/java/org/apache/ranger/services/kylin/RangerServiceKylin.java > PRE-CREATION > > plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinClient.java > PRE-CREATION > > plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinConnectionMgr.java > PRE-CREATION > > plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinResourceMgr.java > PRE-CREATION > > plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/json/model/KylinCubeResponse.java > PRE-CREATION > > plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/json/model/KylinProjectResponse.java > PRE-CREATION > pom.xml 3fcc4aa > ranger-kylin-plugin-shim/.gitignore PRE-CREATION > ranger-kylin-plugin-shim/pom.xml PRE-CREATION > > ranger-kylin-plugin-shim/src/main/java/org/apache/ranger/authorization/kylin/authorizer/RangerKylinAuthorizer.java > PRE-CREATION > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > 9742265 > security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java 722a566 > security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 6e9161e > security-admin/src/main/webapp/scripts/modules/globalize/message/en.js > af7bdfe > security-admin/src/main/webapp/scripts/views/policies/PermissionList.js > 067bf3b > security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js > 6f27d5d > src/main/assembly/admin-web.xml cb1aad2 > src/main/assembly/plugin-kylin.xml PRE-CREATION > > > Diff: https://reviews.apache.org/r/61021/diff/1/ > > > Testing > ------- > > Tested > > > Thanks, > > Qiang Zhang > >
