----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70226/#review213765 -----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicy.java Line 1330 (original), 1359 (patched) <https://reviews.apache.org/r/70226/#comment299751> Renaming existing class RangerPolicyItemCondition can break existing clients if they refer to this class. Introducing RangerPolicyCondition class is a good idea, however, I would suggest to keep RangerPolicyItemCondition as a shell class which simply derives from RangerPolicyCondition - as shown below: public static class RangerPolicyItemCondition extends RangerPolicyCondition implements java.io.Serializable { } Also, for backward compatibility: - retain signature of existing methods that take RangerPolicyItemCondition as paramter/return. New methods in RangerPolicy can use RangerPolicyCondition. - retain existing interfaces/implementations like RangerAbstractConditionEvaluator, RangerConditionEvaluator,.. - madhan On March 17, 2019, 10:15 p.m., Ramesh Mani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70226/ > ----------------------------------------------------------- > > (Updated March 17, 2019, 10:15 p.m.) > > > Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, > Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja > Polavarapu, and Velmurugan Periasamy. > > > Repository: ranger > > > Description > ------- > > RANGER-2354:Add custom condition at policy level > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerAbstractConditionEvaluator.java > ddd1a54 > > agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerConditionEvaluator.java > 16f9a3c > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicy.java > 327d37b > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerAbstractPolicyEvaluator.java > bc459e3 > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java > 3e7c34c > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyItemEvaluator.java > a32322b > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerPolicyEvaluator.java > 5400f71 > > agents-common/src/main/java/org/apache/ranger/services/tag/RangerServiceTag.java > 678e72f > > agents-common/src/test/java/org/apache/ranger/plugin/conditionevaluator/RangerIpMatcherTest.java > 9b221e2 > > agents-common/src/test/java/org/apache/ranger/plugin/conditionevaluator/RangerTimeOfDayMatcherTest.java > ec64e33 > > agents-common/src/test/java/org/apache/ranger/plugin/model/TestRangerPolicy.java > 57e710e > > agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java > 9bd5e24 > > agents-common/src/test/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluatorTest.java > 4fc63da > > agents-common/src/test/resources/policyengine/test_policyengine_policylevel_conditions.json > PRE-CREATION > > ranger-examples/conditions-enrichers/src/test/java/org/apache/ranger/plugin/conditionevaluator/RangerSampleSimpleMatcherTest.java > 22e298d > security-admin/src/main/java/org/apache/ranger/biz/PolicyRefUpdater.java > 25b48bb > > security-admin/src/main/java/org/apache/ranger/biz/RangerPolicyRetriever.java > a000fb5 > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > 4b1c0c4 > security-admin/src/main/java/org/apache/ranger/common/ServiceUtil.java > c82636a > > security-admin/src/main/java/org/apache/ranger/patch/PatchForKafkaServiceDefUpdate_J10025.java > f15a278 > > security-admin/src/main/java/org/apache/ranger/patch/PatchForUpdatingPolicyJson_J10019.java > 1a1cc23 > > security-admin/src/main/java/org/apache/ranger/patch/PatchMigration_J10002.java > 0af7a1d > > security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java > d0f1d93 > security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js > 931babf > security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java > 4d46d0e > security-admin/src/test/java/org/apache/ranger/biz/TestXUserMgr.java > 49c57a6 > security-admin/src/test/java/org/apache/ranger/common/TestServiceUtil.java > 69ac2db > security-admin/src/test/java/org/apache/ranger/rest/TestAssetREST.java > ef149d5 > security-admin/src/test/java/org/apache/ranger/rest/TestPublicAPIs.java > 2bf5ee6 > security-admin/src/test/java/org/apache/ranger/rest/TestPublicAPIsv2.java > f9ea26a > security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java > 8f39607 > > security-admin/src/test/java/org/apache/ranger/service/TestRangerPolicyService.java > d33b24b > > security-admin/src/test/java/org/apache/ranger/service/TestRangerPolicyServiceBase.java > c32422e > > > Diff: https://reviews.apache.org/r/70226/diff/1/ > > > Testing > ------- > > - Tested in local VM with existing RangerSampleProjectProvider condition > enricher and RangerSimpleMatch for policyLevel Custom condition evaluation. > > > Thanks, > > Ramesh Mani > >
