----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70226/#review213999 -----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicyResourceSignature.java Lines 153 (patched) <https://reviews.apache.org/r/70226/#comment300151> customConditionSerialiser will not be null, as it was initialized with "new" in the previous line. Consider the following alternate: if (CollectionUtils.isNotEmpty(_policy.getConditions()) { CustomConditionSerialiser customConditionSerialiser = new CustomConditionSerialiser(_policy.getConditions()); resource += customConditionSerialiser.toString(); } agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicyResourceSignature.java Lines 221 (patched) <https://reviews.apache.org/r/70226/#comment300152> conditionMap is added to 'builder' in every iteration at line #211. Please review and update. - madhan On March 25, 2019, 7:44 p.m., Ramesh Mani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70226/ > ----------------------------------------------------------- > > (Updated March 25, 2019, 7:44 p.m.) > > > Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, > Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja > Polavarapu, and Velmurugan Periasamy. > > > Repository: ranger > > > Description > ------- > > RANGER-2354:Add custom condition at policy level > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerAbstractConditionEvaluator.java > ddd1a54 > > agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerConditionEvaluator.java > 16f9a3c > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicy.java > 327d37b > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicyResourceSignature.java > a1aaa22 > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerAbstractPolicyItemEvaluator.java > f58d514 > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerCustomConditionEvaluator.java > PRE-CREATION > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java > 3e7c34c > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyItemEvaluator.java > a32322b > > agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java > 080efac > > agents-common/src/test/resources/policyengine/test_policyengine_policylevel_conditions.json > PRE-CREATION > > ranger-examples/conditions-enrichers/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerPolicyConditionSampleSimpleMatcher.java > PRE-CREATION > security-admin/src/main/java/org/apache/ranger/biz/PolicyRefUpdater.java > 25b48bb > > security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java > d0f1d93 > > > Diff: https://reviews.apache.org/r/70226/diff/5/ > > > Testing > ------- > > - Tested in local VM with existing RangerSampleProjectProvider condition > enricher and RangerSimpleMatch for policyLevel Custom condition evaluation. > > > Thanks, > > Ramesh Mani > >
