-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70226/#review213877
-----------------------------------------------------------




agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicy.java
Lines 78 (patched)
<https://reviews.apache.org/r/70226/#comment299989>

    Please update RangerPolicyResourceSignature as well, to include 
'conditions' in the generated signature. This will allow multiple policies to 
be created for the same set of resources, with different conditons.


- madhan


On March 20, 2019, 5:03 a.m., Ramesh Mani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70226/
> -----------------------------------------------------------
> 
> (Updated March 20, 2019, 5:03 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, 
> Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja 
> Polavarapu, and Velmurugan Periasamy.
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RANGER-2354:Add custom condition at policy level
> 
> 
> Diffs
> -----
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerAbstractConditionEvaluator.java
>  ddd1a54 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerConditionEvaluator.java
>  16f9a3c 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicy.java 
> 327d37b 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerAbstractPolicyEvaluator.java
>  bc459e3 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java
>  3e7c34c 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerPolicyEvaluator.java
>  5400f71 
>   
> agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java
>  9bd5e24 
>   
> agents-common/src/test/resources/policyengine/test_policyengine_policylevel_conditions.json
>  PRE-CREATION 
>   
> ranger-examples/conditions-enrichers/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerPolicyConditionSampleSimpleMatcher.java
>  PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/biz/PolicyRefUpdater.java 
> 25b48bb 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java
>  d0f1d93 
> 
> 
> Diff: https://reviews.apache.org/r/70226/diff/2/
> 
> 
> Testing
> -------
> 
> - Tested in local VM with existing RangerSampleProjectProvider condition 
> enricher and RangerSimpleMatch for policyLevel Custom condition evaluation.
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>

Reply via email to