----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70057/#review213946 -----------------------------------------------------------
embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java Lines 280 (patched) <https://reviews.apache.org/r/70057/#comment300052> We are catching the exception and ignoring it. What happens when BootStrap is not started? embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/SolrCollectionBoostrapper.java Lines 89 (patched) <https://reviews.apache.org/r/70057/#comment300055> Good to have the unit in the variable name itself. E.g. _MS for milliseconds or _SEC for seconds. embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/SolrCollectionBoostrapper.java Lines 169 (patched) <https://reviews.apache.org/r/70057/#comment300053> Why would these calls give exceptions? If it does, then solrFileDir could be null, which might not be a good thing embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/SolrCollectionBoostrapper.java Lines 175 (patched) <https://reviews.apache.org/r/70057/#comment300054> Don't see any difference for the path in cloud and standalone more. embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/SolrCollectionBoostrapper.java Lines 239 (patched) <https://reviews.apache.org/r/70057/#comment300059> Any reason we are giving write ot others, but not to group? embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/SolrCollectionBoostrapper.java Lines 257 (patched) <https://reviews.apache.org/r/70057/#comment300058> Can we give enough information? E.g. collection name embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/SolrCollectionBoostrapper.java Lines 261 (patched) <https://reviews.apache.org/r/70057/#comment300060> Same here, give more information of the context during error embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/SolrCollectionBoostrapper.java Lines 377 (patched) <https://reviews.apache.org/r/70057/#comment300061> Are we assuming that Solr will be always in Kerberos mode? embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/SolrCollectionBoostrapper.java Lines 389 (patched) <https://reviews.apache.org/r/70057/#comment300062> connect doesn't throw exception, so we should be checking whether it succeeded. embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/SolrCollectionBoostrapper.java Lines 511 (patched) <https://reviews.apache.org/r/70057/#comment300056> Can we print all parameters? Including solr_config_name, max_node_per_shards, etc. embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/SolrCollectionBoostrapper.java Lines 599 (patched) <https://reviews.apache.org/r/70057/#comment300063> Can we document what we are doing here? Seems we are looping and setting/overwriting this variable in some cases embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/SolrCollectionBoostrapper.java Lines 602 (patched) <https://reviews.apache.org/r/70057/#comment300064> Might be good to put couple of lines of documentation on what permissions we are setting and for what purpose - Don Bosco Durai On March 22, 2019, 10:03 a.m., bhavik patel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70057/ > ----------------------------------------------------------- > > (Updated March 22, 2019, 10:03 a.m.) > > > Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay > Kulkarni, Madhan Neethiraj, Oliver Szabo, Pradeep Agrawal, Ramesh Mani, > Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-2324 > https://issues.apache.org/jira/browse/RANGER-2324 > > > Repository: ranger > > > Description > ------- > > We are handling the solr bootstrapping in below mentioned manner for Ranger > 1.) Connection to solr > 2.) Upload Configuration > 3.) Create Collection > 4.) Setting ACL > > > Diffs > ----- > > > embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java > 8d32352 > > embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/SolrCollectionBoostrapper.java > PRE-CREATION > security-admin/scripts/install.properties fdcee1b > security-admin/scripts/setup.sh bd4bd4c > security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml > 686f720 > security-admin/src/main/resources/conf.dist/ranger-admin-site.xml 4d4a1de > src/main/assembly/admin-web.xml 0296652 > > > Diff: https://reviews.apache.org/r/70057/diff/7/ > > > Testing > ------- > > Tested Below Scenario on ranger manual start / restart > 1.) Solr configuration were uploaded successfully > 2.) Solr collections were created successfully > 3.) ACL were setup as required. > > > Thanks, > > bhavik patel > >
