> On March 23, 2019, 4:49 p.m., Don Bosco Durai wrote: > > embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java > > Lines 280 (patched) > > <https://reviews.apache.org/r/70057/diff/7/?file=2133415#file2133415line280> > > > > We are catching the exception and ignoring it. What happens when > > BootStrap is not started?
We are logging the error and going ahead to start the ranger service. Its like we should not stop ranger from starting in case solr setup is fails for some reason such no live node available , not able to connect etc. If solr setup fails the process should try again after supplied interval of time. > On March 23, 2019, 4:49 p.m., Don Bosco Durai wrote: > > embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/SolrCollectionBoostrapper.java > > Lines 169 (patched) > > <https://reviews.apache.org/r/70057/diff/7/?file=2133416#file2133416line169> > > > > Why would these calls give exceptions? If it does, then solrFileDir > > could be null, which might not be a good thing basedir can never be null. > On March 23, 2019, 4:49 p.m., Don Bosco Durai wrote: > > embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/SolrCollectionBoostrapper.java > > Lines 175 (patched) > > <https://reviews.apache.org/r/70057/diff/7/?file=2133416#file2133416line175> > > > > Don't see any difference for the path in cloud and standalone more. pathForCloud = {solrFileDir}/contrib/solr_for_audit_setup/conf pathForStandalone = {solrFileDir}/contrib/solr_for_audit_setup > On March 23, 2019, 4:49 p.m., Don Bosco Durai wrote: > > embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/SolrCollectionBoostrapper.java > > Lines 239 (patched) > > <https://reviews.apache.org/r/70057/diff/7/?file=2133416#file2133416line239> > > > > Any reason we are giving write ot others, but not to group? Solr user will be creating properties file and data dir on standalone location. Added comment for other developer reference > On March 23, 2019, 4:49 p.m., Don Bosco Durai wrote: > > embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/SolrCollectionBoostrapper.java > > Lines 377 (patched) > > <https://reviews.apache.org/r/70057/diff/7/?file=2133416#file2133416line377> > > > > Are we assuming that Solr will be always in Kerberos mode? Added Kerberos check before calling this method. > On March 23, 2019, 4:49 p.m., Don Bosco Durai wrote: > > embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/SolrCollectionBoostrapper.java > > Lines 389 (patched) > > <https://reviews.apache.org/r/70057/diff/7/?file=2133416#file2133416line389> > > > > connect doesn't throw exception, so we should be checking whether it > > succeeded. solrCloudClient.connect() is the void method. i have added null check for zkClient > On March 23, 2019, 4:49 p.m., Don Bosco Durai wrote: > > embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/SolrCollectionBoostrapper.java > > Lines 599 (patched) > > <https://reviews.apache.org/r/70057/diff/7/?file=2133416#file2133416line599> > > > > Can we document what we are doing here? Seems we are looping and > > setting/overwriting this variable in some cases Added comment as part of method description. > On March 23, 2019, 4:49 p.m., Don Bosco Durai wrote: > > embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/SolrCollectionBoostrapper.java > > Lines 602 (patched) > > <https://reviews.apache.org/r/70057/diff/7/?file=2133416#file2133416line602> > > > > Might be good to put couple of lines of documentation on what > > permissions we are setting and for what purpose Added comment as part of method description. - bhavik ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70057/#review213946 ----------------------------------------------------------- On March 25, 2019, 9:42 a.m., bhavik patel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70057/ > ----------------------------------------------------------- > > (Updated March 25, 2019, 9:42 a.m.) > > > Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay > Kulkarni, Madhan Neethiraj, Oliver Szabo, Pradeep Agrawal, Ramesh Mani, > Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-2324 > https://issues.apache.org/jira/browse/RANGER-2324 > > > Repository: ranger > > > Description > ------- > > We are handling the solr bootstrapping in below mentioned manner for Ranger > 1.) Connection to solr > 2.) Upload Configuration > 3.) Create Collection > 4.) Setting ACL > > > Diffs > ----- > > > embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java > 8d32352 > > embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/SolrCollectionBoostrapper.java > PRE-CREATION > security-admin/scripts/install.properties fdcee1b > security-admin/scripts/setup.sh bd4bd4c > security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml > 686f720 > security-admin/src/main/resources/conf.dist/ranger-admin-site.xml 4d4a1de > src/main/assembly/admin-web.xml 0296652 > > > Diff: https://reviews.apache.org/r/70057/diff/8/ > > > Testing > ------- > > Tested Below Scenario on ranger manual start / restart > 1.) Solr configuration were uploaded successfully > 2.) Solr collections were created successfully > 3.) ACL were setup as required. > > > Thanks, > > bhavik patel > >
