> On April 13, 2020, 4:40 a.m., Madhan Neethiraj wrote:
> > plugin-presto/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControl.java
> > Lines 206 (patched)
> > <https://reviews.apache.org/r/72272/diff/6/?file=2217408#file2217408line215>
> >
> > None of the mask-types have token {type}; what is the use case to
> > replace this token in the transformer?
Presto requires types to remain the same when masking (e.g. an varchar should
remain a varchar). This token gives the flexibility to cast to the right {type}
when masking as that will contain the original type.
> On April 13, 2020, 4:40 a.m., Madhan Neethiraj wrote:
> > plugin-presto/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControl.java
> > Line 140 (original), 307 (patched)
> > <https://reviews.apache.org/r/72272/diff/6/?file=2217408#file2217408line317>
> >
> > Are info level logs here and rest of this class intentional? If not,
> > consider changing to debug level.
Good point, will fix that.
- Bolke
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72272/#review220292
-----------------------------------------------------------
On April 13, 2020, 11:39 a.m., Bolke de Bruin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72272/
> -----------------------------------------------------------
>
> (Updated April 13, 2020, 11:39 a.m.)
>
>
> Review request for ranger, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal,
> and Ramesh Mani.
>
>
> Bugs: https://issues.apache.org/jira/browse/RANGER-2754
>
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/RANGER-2754
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Upgrade and improve Presto plugin
> - Presto SQL 331 has changed its security API and has Row level / column
> masking functionality
> - Upgraded Hadoop dependency to 3.1.3 (from 3.1.1) due to improved security
> handling
> - New features like session properties and system properties
>
>
> Diffs
> -----
>
> agents-common/src/main/resources/service-defs/ranger-servicedef-presto.json
> 56a8f5ac0
> distro/src/main/assembly/plugin-presto.xml d2075bfe7
> plugin-presto/pom.xml b63f7dede
>
> plugin-presto/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControl.java
> 3ab63f590
>
> plugin-presto/src/test/java/org/apache/ranger/authorization/presto/authorizer/RangerAdminClientImpl.java
> PRE-CREATION
>
> plugin-presto/src/test/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControlTest.java
> PRE-CREATION
> plugin-presto/src/test/resources/log4j.properties PRE-CREATION
> plugin-presto/src/test/resources/presto-policies.json PRE-CREATION
> plugin-presto/src/test/resources/ranger-presto-security.xml PRE-CREATION
> pom.xml b62d9b663
> ranger-presto-plugin-shim/pom.xml d8ff88d0f
>
> ranger-presto-plugin-shim/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerConfig.java
> 67b0d2434
>
> ranger-presto-plugin-shim/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControl.java
> e89f646e1
>
>
> Diff: https://reviews.apache.org/r/72272/diff/7/
>
>
> Testing
> -------
>
> - New Unit tests added
> - Tested locally in production
>
>
> Thanks,
>
> Bolke de Bruin
>
>
