> On April 13, 2020, 10:16 p.m., Madhan Neethiraj wrote: > > Unit tests fail with this patch - see below for details. This is likely > > caused by change of Hadoop version in this patch (3.1.1 => 3.1.3). Please > > review and update. > > > > > > > > mvn clean package > > ... > > > > [ERROR] Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: > > 0.606 s <<< FAILURE! - in > > org.apache.ranger.services.hive.HIVERangerAuthorizerTest > > [ERROR] org.apache.ranger.services.hive.HIVERangerAuthorizerTest Time > > elapsed: 0.606 s <<< ERROR! > > java.lang.NoSuchMethodError: > > com.google.common.base.Preconditions.checkArgument(ZLjava/lang/String;Ljava/lang/Object;)V > > at > > org.apache.ranger.services.hive.HIVERangerAuthorizerTest.setup(HIVERangerAuthorizerTest.java:73) > > > > [ERROR] org.apache.ranger.services.hive.HIVERangerAuthorizerTest Time > > elapsed: 0.606 s <<< ERROR! > > java.lang.NullPointerException > > at > > org.apache.ranger.services.hive.HIVERangerAuthorizerTest.cleanup(HIVERangerAuthorizerTest.java:150) > > > > [INFO] > > [INFO] Results: > > [INFO] > > [ERROR] Errors: > > [ERROR] > > org.apache.ranger.services.hive.HIVERangerAuthorizerTest.org.apache.ranger.services.hive.HIVERangerAuthorizerTest > > [ERROR] Run 1: HIVERangerAuthorizerTest.setup:73 ยป NoSuchMethod > > com.google.common.base.Precon... > > [ERROR] Run 2: HIVERangerAuthorizerTest.cleanup:150 NullPointer > > [INFO] > > [INFO] > > [ERROR] Tests run: 2, Failures: 0, Errors: 1, Skipped: 0 > > ... > > [INFO] HBase Security Plugin .............................. SUCCESS [ > > 7.327 s] > > [INFO] Hdfs Security Plugin ............................... SUCCESS [ > > 13.133 s] > > [INFO] Hive Security Plugin ............................... FAILURE [ > > 9.044 s] > > [INFO] Knox Security Plugin Shim .......................... SKIPPED > > ... > > [INFO] Apache Ranger Distribution ......................... SKIPPED > > [INFO] > > ------------------------------------------------------------------------ > > [INFO] BUILD FAILURE > > [INFO] > > ------------------------------------------------------------------------ > > [INFO] Total time: 01:14 min > > [INFO] Finished at: 2020-04-13T15:08:52-07:00 > > [INFO] > > ------------------------------------------------------------------------ > > [ERROR] Failed to execute goal > > org.apache.maven.plugins:maven-surefire-plugin:2.21.0:test (default-test) > > on project ranger-hive-plugin: There are test failures.
I have been able to reproduce it, although it works in the idea. Tests run: 27, Failures: 0, Errors: 0, Skipped: 3, Time elapsed: 30.037 s - in org.apache.ranger.services.hive.HIVERangerAuthorizerTest - Bolke ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72272/#review220301 ----------------------------------------------------------- On April 13, 2020, 11:39 a.m., Bolke de Bruin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72272/ > ----------------------------------------------------------- > > (Updated April 13, 2020, 11:39 a.m.) > > > Review request for ranger, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, > and Ramesh Mani. > > > Bugs: https://issues.apache.org/jira/browse/RANGER-2754 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/RANGER-2754 > > > Repository: ranger > > > Description > ------- > > Upgrade and improve Presto plugin > - Presto SQL 331 has changed its security API and has Row level / column > masking functionality > - Upgraded Hadoop dependency to 3.1.3 (from 3.1.1) due to improved security > handling > - New features like session properties and system properties > > > Diffs > ----- > > agents-common/src/main/resources/service-defs/ranger-servicedef-presto.json > 56a8f5ac0 > distro/src/main/assembly/plugin-presto.xml d2075bfe7 > plugin-presto/pom.xml b63f7dede > > plugin-presto/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControl.java > 3ab63f590 > > plugin-presto/src/test/java/org/apache/ranger/authorization/presto/authorizer/RangerAdminClientImpl.java > PRE-CREATION > > plugin-presto/src/test/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControlTest.java > PRE-CREATION > plugin-presto/src/test/resources/log4j.properties PRE-CREATION > plugin-presto/src/test/resources/presto-policies.json PRE-CREATION > plugin-presto/src/test/resources/ranger-presto-security.xml PRE-CREATION > pom.xml b62d9b663 > ranger-presto-plugin-shim/pom.xml d8ff88d0f > > ranger-presto-plugin-shim/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerConfig.java > 67b0d2434 > > ranger-presto-plugin-shim/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControl.java > e89f646e1 > > > Diff: https://reviews.apache.org/r/72272/diff/7/ > > > Testing > ------- > > - New Unit tests added > - Tested locally in production > > > Thanks, > > Bolke de Bruin > >
