----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73252/#review222813 -----------------------------------------------------------
Fix it, then Ship it! security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java Line 5170 (original), 5170 (patched) <https://reviews.apache.org/r/73252/#comment311995> resourcePolicy: consider renaming to accessPolicy, to avoid confusion on tagPolicy vs resourcePolicy. Please review other occurrences as well. security-admin/src/main/java/org/apache/ranger/patch/cliutil/MetricUtil.java Line 293 (original), 293 (patched) <https://reviews.apache.org/r/73252/#comment311996> resourcePolicy: consider renaming to accessPolicy, to avoid confusion on tagPolicy vs resourcePolicy. Please review other occurrences as well. - Madhan Neethiraj On April 12, 2021, 7:29 a.m., Mahesh Bandal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73252/ > ----------------------------------------------------------- > > (Updated April 12, 2021, 7:29 a.m.) > > > Review request for ranger, Ankita Sinha, bhavik patel, Gautam Borad, Kishor > Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep > Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-3215 > https://issues.apache.org/jira/browse/RANGER-3215 > > > Repository: ranger > > > Description > ------- > > When Ranger Metric Util is called and auditDBType="solr", the process does > not exit and keeps consuming more heap-size than normally required. Solr > server throws : Java heap space OutOfMemoryError for large number of audits. > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > a7871eda8 > > security-admin/src/main/java/org/apache/ranger/patch/cliutil/MetricUtil.java > 3bc581e73 > > > Diff: https://reviews.apache.org/r/73252/diff/2/ > > > Testing > ------- > > 1. In case of Audit to Solr, MetricUtil works as expected. > > > Thanks, > > Mahesh Bandal > >
