> On April 13, 2021, 4:29 p.m., Madhan Neethiraj wrote: > > security-admin/src/main/java/org/apache/ranger/patch/cliutil/MetricUtil.java > > Line 293 (original), 293 (patched) > > <https://reviews.apache.org/r/73252/diff/2/?file=2248738#file2248738line293> > > > > resourcePolicy: consider renaming to accessPolicy, to avoid confusion > > on tagPolicy vs resourcePolicy. > > > > Please review other occurrences as well. > > Mahesh Bandal wrote: > RangerPolicy class have following policyTypes: > POLICY_TYPE_ACCESS = 0; > POLICY_TYPE_DATAMASK = 1; > POLICY_TYPE_ROWFILTER = 2; > > There are four different categories made for policyCountList in > MetricUtil: > 1. resourcePolicy > 2. tagBasedPolicies > 3. rowFilteringPolicies > 4. maskingPolicies > > Among those, resourcePolicy & tagBasedPolicies have policyType='Access' > > Is it alright to rename resourcePolicy to accessPolicy?
ok. To capture such granularity, perhaps following names can help: - resourcePolicy => resourceAccessPolicy - tagBasedPolicy => tagAccessPolicy Are tag-based masking policies tracked seperately from resource-based masking policies? If yes, maskingPolicies needs to be split into: - resourceMaskingPolicy - tagMaskingPolicy - Madhan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73252/#review222813 ----------------------------------------------------------- On April 12, 2021, 7:29 a.m., Mahesh Bandal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73252/ > ----------------------------------------------------------- > > (Updated April 12, 2021, 7:29 a.m.) > > > Review request for ranger, Ankita Sinha, bhavik patel, Gautam Borad, Kishor > Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep > Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-3215 > https://issues.apache.org/jira/browse/RANGER-3215 > > > Repository: ranger > > > Description > ------- > > When Ranger Metric Util is called and auditDBType="solr", the process does > not exit and keeps consuming more heap-size than normally required. Solr > server throws : Java heap space OutOfMemoryError for large number of audits. > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > a7871eda8 > > security-admin/src/main/java/org/apache/ranger/patch/cliutil/MetricUtil.java > 3bc581e73 > > > Diff: https://reviews.apache.org/r/73252/diff/2/ > > > Testing > ------- > > 1. In case of Audit to Solr, MetricUtil works as expected. > > > Thanks, > > Mahesh Bandal > >
