----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74224/#review224924 -----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerServiceResource.java Lines 45 (patched) <https://reviews.apache.org/r/74224/#comment313775> Classes in 'model' package are used in REST APIs, hence I suggest to not make this change unless both client and server require this. security-admin/src/main/java/org/apache/ranger/biz/TagDBStore.java Line 1227 (original), 1244 (patched) <https://reviews.apache.org/r/74224/#comment313777> Consider avoiding creation of Lists.newArrayList() in every iteration by using switch/case, like: switch (record.getChangeType()) { case ServiceTags.TagsChangeType.TAG_UPDATE.ordinal(): tagIds.add(record.getTagId()); break; case ServiceTags.TagsChangeType.SERVICE_RESOURCE_CREATE.ordinal(): case ServiceTags.TagsChangeType.SERVICE_RESOURCE_UPDATE.ordinal(): case ServiceTags.TagsChangeType.SERVICE_RESOURCE_DELETE.ordinal(): serviceResourceIds.add(record.getServiceResourceId()); break; case ServiceTags.TagsChangeType.TAG_RESOURCE_MAP_CREATE.ordinal(): case ServiceTags.TagsChangeType.TAG_RESOURCE_MAP_UPDATE.ordinal(): case ServiceTags.TagsChangeType.TAG_RESOURCE_MAP_DELETE.ordinal(): tagIds.add(record.getTagId()); serviceResourceIds.add(record.getServiceResourceId()); break; default: if (LOG.isDebugEnabled()) { LOG.debug("Unknown changeType in tag-change-log record: [" + record + "]"); LOG.debug("Returning without further processing"); tagIds.clear(); serviceResourceIds.clear(); break; } - Madhan Neethiraj On Dec. 1, 2022, 6:47 a.m., zhou feng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74224/ > ----------------------------------------------------------- > > (Updated Dec. 1, 2022, 6:47 a.m.) > > > Review request for ranger, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, > Nikhil P, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja > Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-3950 > https://issues.apache.org/jira/browse/RANGER-3950 > > > Repository: ranger > > > Description > ------- > > Fix the change of tag, tag-resource map , service resource is recorded to > x_tag_change_log > https://issues.apache.org/jira/browse/RANGER-3950 > add the type of change of tag follow : > TAG_RESOURCE_MAP_CREATE , TAG_RESOURCE_MAP_DELETE , SERVICE_RESOURCE_CREATE > , SERVICE_RESOURCE_DELETE > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerServiceResource.java > b7cf7cebb > agents-common/src/main/java/org/apache/ranger/plugin/util/ServiceTags.java > 9b902789a > security-admin/src/main/java/org/apache/ranger/biz/TagDBStore.java > e434cf1bb > > security-admin/src/main/java/org/apache/ranger/service/RangerServiceResourceServiceBase.java > 329d3eeec > > > Diff: https://reviews.apache.org/r/74224/diff/1/ > > > Testing > ------- > > Tested the below Rest API's to make sure everything works fine > 1.POST /service/tags/tags > 2.PUT /service/tag/guid/{guid} > 3.DELETE /service/tag/{id} > 4.POST /service/resources > 5.PUT /service/resource/{id} > 6.DELETE /service/resource/{id} > > > Thanks, > > zhou feng > >
