----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74224/#review224996 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/biz/TagDBStore.java Lines 538 (patched) <https://reviews.apache.org/r/74224/#comment313815> Change log for TagsChangeType.SERVICE_RESOURCE_UPDATE is already being created currently. Hence #538 - #542 are not necessary. security-admin/src/main/java/org/apache/ranger/biz/TagDBStore.java Lines 1413 (patched) <https://reviews.apache.org/r/74224/#comment313814> These additional calls to DB can result in significant performance impact especially while importing large number of tags via TagREST.importServiceTags() API. To improve performance in loading tags from the database, all tags associated with a resource are stroed along with resource itself (XXServiceResource.tags). Hence it is not necessary to track create/delete tag-resource-map and service-resource via TagChangeLog entries. Are here any specific usecase that requires tracking create/delete of tag-resource-map and service-resource via TagChangeLog entries? It will help to update the JIRA with this detail. If these additional change logs become necessary, I suggest to use a flag to disable additional change-logs for deployments that don't require them. - Madhan Neethiraj On Dec. 12, 2022, 1:43 a.m., zhou feng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74224/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2022, 1:43 a.m.) > > > Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, > Mehul Parikh, Nikhil P, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, > Sailaja Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy. > > > Bugs: RANGER-3950 > https://issues.apache.org/jira/browse/RANGER-3950 > > > Repository: ranger > > > Description > ------- > > Fix the change of tag, tag-resource map , service resource is recorded to > x_tag_change_log > https://issues.apache.org/jira/browse/RANGER-3950 > add the type of change of tag follow : > TAG_RESOURCE_MAP_CREATE , TAG_RESOURCE_MAP_DELETE , SERVICE_RESOURCE_CREATE > , SERVICE_RESOURCE_DELETE > > > Diffs > ----- > > agents-common/src/main/java/org/apache/ranger/plugin/util/ServiceTags.java > 9b902789a > security-admin/src/main/java/org/apache/ranger/biz/TagDBStore.java > e434cf1bb > > > Diff: https://reviews.apache.org/r/74224/diff/2/ > > > Testing > ------- > > Tested the below Rest API's to make sure everything works fine > 1.POST /service/tags/tags > 2.PUT /service/tag/guid/{guid} > 3.DELETE /service/tag/{id} > 4.POST /service/resources > 5.PUT /service/resource/{id} > 6.DELETE /service/resource/{id} > > > Thanks, > > zhou feng > >
