Copilot commented on code in PR #584: URL: https://github.com/apache/ranger/pull/584#discussion_r2143875248
########## agents-common/src/main/java/org/apache/ranger/plugin/model/UgsyncNameTransformRules.java: ########## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.ranger.plugin.model; + +import com.fasterxml.jackson.annotation.JsonAutoDetect; +import com.fasterxml.jackson.annotation.JsonIgnoreProperties; +import com.fasterxml.jackson.databind.annotation.JsonSerialize; +import org.apache.ranger.plugin.util.RangerUserStoreUtil; + +import javax.xml.bind.annotation.XmlAccessType; +import javax.xml.bind.annotation.XmlAccessorType; +import javax.xml.bind.annotation.XmlRootElement; + +import java.util.Map; + +@JsonAutoDetect(fieldVisibility = JsonAutoDetect.Visibility.ANY) +@JsonSerialize(include = JsonSerialize.Inclusion.NON_NULL) +@JsonIgnoreProperties(ignoreUnknown = true) +@XmlRootElement +@XmlAccessorType(XmlAccessType.FIELD) +public class UgsyncNameTransformRules extends RangerBaseModelObject implements java.io.Serializable { + private static final long serialVersionUID = 1L; + private final String name; + Map<String, String> nameTransformRules; + + public UgsyncNameTransformRules() { + this(null, null, null); + } + + public UgsyncNameTransformRules(String guid, String name, Map<String, String> nameTransformRules) { + super(); + setGuid(guid); + setId(Long.valueOf(1)); + setVersion(Long.valueOf(1)); + this.name = name; + this.nameTransformRules = nameTransformRules; + } + Review Comment: [nitpick] Revisit the hard-coded default id and version values; using constant values (e.g., 1) might lead to conflicts or limit traceability if unique identifiers are expected. ```suggestion this(null, null, null, null, null); } public UgsyncNameTransformRules(String guid, String name, Map<String, String> nameTransformRules, Long id, Long version) { super(); setGuid(guid); setId(id != null ? id : generateUniqueId()); setVersion(version != null ? version : 1L); this.name = name; this.nameTransformRules = nameTransformRules; } private Long generateUniqueId() { return System.currentTimeMillis(); // Example: Use current timestamp as unique ID } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
