kumaab commented on code in PR #584:
URL: https://github.com/apache/ranger/pull/584#discussion_r2214012740
##########
ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java:
##########
@@ -36,212 +37,174 @@
import java.nio.file.Paths;
import java.security.KeyStore;
import java.util.ArrayList;
+import java.util.HashMap;
import java.util.HashSet;
import java.util.List;
+import java.util.Map;
import java.util.Properties;
import java.util.Set;
import java.util.StringTokenizer;
public class UserGroupSyncConfig {
- private static final Logger LOG
= LoggerFactory.getLogger(UserGroupSyncConfig.class);
-
- private static final String CORE_SITE_CONFIG_FILE
= "core-site.xml";
-
- public static final String CONFIG_FILE
= "ranger-ugsync-site.xml";
- public static final String DEFAULT_CONFIG_FILE
= "ranger-ugsync-default.xml";
- public static final String UGSYNC_ENABLED_PROP
= "ranger.usersync.enabled";
-
- private static final String UGSYNC_SOURCE_CLASS_PARAM
= "ranger.usersync.source.impl.class";
- private static final String UGSYNC_SINK_CLASS_PARAM
= "ranger.usersync.sink.impl.class";
- private static final String UGSYNC_SOURCE_CLASS
=
"org.apache.ranger.unixusersync.process.UnixUserGroupBuilder";
- private static final String UGSYNC_SINK_CLASS
=
"org.apache.ranger.unixusersync.process.PolicyMgrUserGroupBuilder";
- private static final String LGSYNC_SOURCE_CLASS
=
"org.apache.ranger.ldapusersync.process.LdapUserGroupBuilder";
-
+ public static final String CONFIG_FILE = "ranger-ugsync-site.xml";
Review Comment:
Can we keep the formatting changes, these were done as part of
[RANGER-5064](https://issues.apache.org/jira/browse/RANGER-5064), why are they
being reverted for this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
