mneethiraj commented on code in PR #595:
URL: https://github.com/apache/ranger/pull/595#discussion_r2302442775
##########
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java:
##########
@@ -1455,4 +1492,18 @@ private static final class LogHistory {
long lastLogTime;
int counter;
}
+
+ private boolean isSynchronousPolicyCacheUpdateEnabled() {
+ boolean ret = false;
+ if (this.getServiceConfigs() != null && this.pluginConfig != null &&
this.pluginConfig.getServiceType() != null) {
+ String configPolicyCacheRefreshMode =
"ranger.plugins.conf.policy.cache.refresh.mode";
Review Comment:
- to be consistent with rest of policy related plugin configurations, I
suggest using properyy prefix `ranger.plugin.<serviceType>.policy.`
- I suggest renaming `cache.refresh.mode` to `refresh.synchronous`, with
default value as `faise`
`ranger.plugin.hive.policy.refresh.synchronous`
- `isSynchronousPolicyCacheUpdateEnabled()` => `isSynchronousPolicyRefresh()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
