fateh288 commented on code in PR #595:
URL: https://github.com/apache/ranger/pull/595#discussion_r2302556872


##########
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java:
##########
@@ -1455,4 +1492,18 @@ private static final class LogHistory {
         long lastLogTime;
         int  counter;
     }
+
+    private boolean isSynchronousPolicyCacheUpdateEnabled() {
+        boolean ret = false;
+        if (this.getServiceConfigs() != null && this.pluginConfig != null && 
this.pluginConfig.getServiceType() != null) {
+            String configPolicyCacheRefreshMode = 
"ranger.plugins.conf.policy.cache.refresh.mode";

Review Comment:
   @mneethiraj 
   1) The convention that "ranger admin configs" starting with 
ranger.plugins.conf will sync as service configs to all the plugins has been 
introduced in [RANGER-5215](https://issues.apache.org/jira/browse/RANGER-5215):
   
https://github.com/apache/ranger/blob/master/security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java#L233
 
   The property prefix you are mentioning will be used when the property needs 
to be set at "per service level". Anything starting with ranger.plugins.conf 
will be synced to all services -- thus I have used it here
   
   2) Addressed
   3) Addressed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to