fateh288 commented on code in PR #595:
URL: https://github.com/apache/ranger/pull/595#discussion_r2302610095


##########
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java:
##########
@@ -1455,4 +1492,18 @@ private static final class LogHistory {
         long lastLogTime;
         int  counter;
     }
+
+    private boolean isSynchronousPolicyCacheUpdateEnabled() {
+        boolean ret = false;
+        if (this.getServiceConfigs() != null && this.pluginConfig != null && 
this.pluginConfig.getServiceType() != null) {
+            String configPolicyCacheRefreshMode = 
"ranger.plugins.conf.policy.cache.refresh.mode";

Review Comment:
   But we want to set it at ranger admin level via ranger-admin-site.xml and 
not via service configs from Ranger UI / repo settings. 
   If we want to set this config on a per service basis from Ranger UI, then we 
can do what you are recommending --- my initial implementation / commit in this 
PR had this implementation but I changed it after discussion with @spolavarapu1 
   We can go either ways depending on our need - whether we want to set it on 
per service level from ranger UI service configs or at once via ranger admin 
configs



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to