Copilot commented on code in PR #810: URL: https://github.com/apache/ranger/pull/810#discussion_r2706566952
########## dev-support/ranger-docker/scripts/solr/ranger-solr-plugin-install.properties: ########## @@ -0,0 +1,92 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +POLICY_MGR_URL=http://ranger:6080 +REPOSITORY_NAME=dev_solr +COMPONENT_INSTALL_DIR_NAME=/opt/solr/server +UGI_INITIALIZE=true +UGI_LOGIN_TYPE=jaas +UGI_JAAS_APPCONFIG=Client + +XAAUDIT.SOLR.IS_ENABLED=true +XAAUDIT.SOLR.MAX_QUEUE_SIZE=1 +XAAUDIT.SOLR.MAX_FLUSH_INTERVAL_MS=1000 +XAAUDIT.SOLR.SOLR_URL=http://ranger-solr:8983/solr/ranger_audits + +# Following properties are needed to get past installation script! Please don't remove +XAAUDIT.HDFS.IS_ENABLED=false +XAAUDIT.HDFS.DESTINATION_DIRECTORY=/ranger/audit +XAAUDIT.HDFS.DESTINTATION_FILE=solr +XAAUDIT.HDFS.DESTINTATION_FLUSH_INTERVAL_SECONDS=900 +XAAUDIT.HDFS.DESTINTATION_ROLLOVER_INTERVAL_SECONDS=86400 +XAAUDIT.HDFS.DESTINTATION_OPEN_RETRY_INTERVAL_SECONDS=60 Review Comment: Corrected spelling of 'DESTINTATION' to 'DESTINATION'. ```suggestion XAAUDIT.HDFS.DESTINATION_FILE=solr XAAUDIT.HDFS.DESTINATION_FLUSH_INTERVAL_SECONDS=900 XAAUDIT.HDFS.DESTINATION_ROLLOVER_INTERVAL_SECONDS=86400 XAAUDIT.HDFS.DESTINATION_OPEN_RETRY_INTERVAL_SECONDS=60 ``` ########## dev-support/ranger-docker/scripts/solr/ranger-solr.sh: ########## @@ -18,19 +18,11 @@ SOLR_INSTALL_DIR=/opt/solr -if [ ! -e ${SOLR_INSTALL_DIR}/.setupDone ] -then - if [ "${KERBEROS_ENABLED}" == "true" ] - then - ${RANGER_SCRIPTS}/wait_for_keytab.sh HTTP.keytab - ${RANGER_SCRIPTS}/wait_for_testusers_keytab.sh - fi - - touch "${SOLR_INSTALL_DIR}"/.setupDone -fi - if [ "${KERBEROS_ENABLED}" == "true" ] then + ${RANGER_SCRIPTS}/wait_for_keytab.sh HTTP.keytab Review Comment: The script waits for HTTP.keytab but the solr-jaas.conf has been updated to use solr.keytab (line 22 of solr-jaas.conf). This wait should be updated to 'solr.keytab' to match the new principal configuration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
