Copilot commented on code in PR #810: URL: https://github.com/apache/ranger/pull/810#discussion_r2706579955
########## plugin-solr/conf/ranger-solr-audit-changes.cfg: ########## @@ -26,13 +26,19 @@ xasecure.audit.hdfs.config.local.buffer.rollover.interval.seconds %XAAUDIT.HDFS xasecure.audit.hdfs.config.local.archive.directory %XAAUDIT.HDFS.LOCAL_ARCHIVE_DIRECTORY% mod create-if-not-exists xasecure.audit.hdfs.config.local.archive.max.file.count %XAAUDIT.HDFS.LOCAL_ARCHIVE_MAX_FILE_COUNT% mod create-if-not-exists +#xasecure.audit.kafka.is.enabled %XAAUDIT.KAFKA.IS_ENABLED% mod create-if-not-exists +#xasecure.audit.kafka.is.async %XAAUDIT.KAFKA.IS_ASYNC% mod create-if-not-exists +#xasecure.audit.kafka.async.max.queue.size %XAAUDIT.KAFKA.MAX_QUEUE_SIZE% mod create-if-not-exists +#xasecure.audit.kafka.async.max.flush.interval.ms %XAAUDIT.KAFKA.MAX_FLUSH_INTERVAL_MS% mod create-if-not-exists +#xasecure.audit.kafka.broker_list %XAAUDIT.KAFKA.BROKER_LIST% mod create-if-not-exists +#xasecure.audit.kafka.topic_name %XAAUDIT.KAFKA.TOPIC_NAME% mod create-if-not-exists + xasecure.audit.solr.is.enabled %XAAUDIT.SOLR.IS_ENABLED% mod create-if-not-exists +xasecure.audit.solr.async.max.queue.size %XAAUDIT.SOLR.MAX_QUEUE_SIZE% mod create-if-not-exists +xasecure.audit.solr.async.max.flush.interval.ms %XAAUDIT.SOLR.MAX_FLUSH_INTERVAL_MS% mod create-if-not-exists xasecure.audit.solr.solr_url %XAAUDIT.SOLR.SOLR_URL% mod create-if-not-exists - #V3 configuration Review Comment: The configuration property name 'xasecure.audit.destination.solr' is inconsistent with the variable placeholder '%XAAUDIT.SOLR.ENABLE%'. The variable uses 'XAAUDIT' while the property uses 'xasecure'. Consider ensuring consistency in naming conventions or documenting the mapping between legacy 'xasecure' properties and newer 'XAAUDIT' variable names. ```suggestion # V3 configuration # Note: 'xasecure.audit.*' properties are legacy/compatibility keys that are # intentionally mapped to newer '%XAAUDIT.*%' variables. The Solr destination # properties below follow this same pattern, so the different prefixes are # by design and should not be considered a mismatch. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
