kumaab commented on code in PR #810:
URL: https://github.com/apache/ranger/pull/810#discussion_r2706920269
##########
dev-support/ranger-docker/Dockerfile.ranger-solr:
##########
@@ -37,5 +39,18 @@ COPY ./scripts/kdc/krb5.conf /etc/krb5.conf
RUN chown -R solr:solr /opt/solr/server/solr/configsets/ranger_audits/
RUN chmod +x /home/ranger/scripts/ranger-solr.sh
/home/ranger/scripts/wait_for_keytab.sh
/home/ranger/scripts/wait_for_testusers_keytab.sh
+# Copy Ranger plugin
+RUN mkdir -p /opt/ranger /home/ranger/dist /home/ranger/scripts
+
+COPY ./dist/ranger-${SOLR_PLUGIN_VERSION}-solr-plugin.tar.gz /home/ranger/dist/
+COPY ./scripts/solr/core-site.xml
/home/ranger/scripts/
Review Comment:
L46-L47: Volume mounts can be used to mount the .xml and .properties file,
using docker-compose.yaml file after which L46-L47 may be removed. It's
preferable to keep configs outside the docker image. thanks.
With volume mount in place, this can be added in RUN at L49:
`rm -f /opt/ranger/ranger-solr-plugin/install.properties`
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
