ramackri commented on code in PR #986:
URL: https://github.com/apache/ranger/pull/986#discussion_r3378209449


##########
audit-server/audit-dispatcher/dispatcher-common/pom.xml:
##########
@@ -147,6 +147,20 @@
             <artifactId>spring-context</artifactId>
             <version>${springframework.version}</version>
         </dependency>
+
+        <!-- Test -->
+        <dependency>
+            <groupId>org.junit.jupiter</groupId>
+            <artifactId>junit-jupiter</artifactId>
+            <version>${junit.jupiter.version}</version>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
+            <groupId>org.mockito</groupId>
+            <artifactId>mockito-core</artifactId>
+            <version>${mockito.version}</version>
+            <scope>test</scope>
+        </dependency>

Review Comment:
   JUnit/Mockito were added to dispatcher-common but the mapper moved out and 
there are no tests there. Remove those dependencies unless tests are added.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to