paras200 commented on PR #986: URL: https://github.com/apache/ranger/pull/986#issuecomment-4678919883
@ramackri The checkstyle violations are all `LineLength > 80` and `JavadocVariable` (missing Javadoc on private fields). These are the same class of violations present across the existing dispatcher modules — for example, `dispatcher-solr` has 101 identical violations and passes CI without issue. The 80-character line limit is explicitly deprecated per the [Apache Ranger Java Style Guide](https://cwiki.apache.org/confluence/display/RANGER/Apache+Ranger+Java+Style+Guide) which sets the column limit at 512 characters. @mneethiraj also confirmed in this PR review: "days of 80-character max width are long gone." The `JavadocVariable` violations are on private constants/fields — adding Javadoc to these would contradict the coding guideline to avoid unnecessary comments when identifiers are self-explanatory. The CI `build-17` failure is unrelated to checkstyle — it's a timeout in `TestGdsREST` in `security-admin` (same issue affecting other PRs like RANGER-5637). The checkstyle plugin is not configured as a CI gate for this module. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
