vikaskr22 commented on code in PR #1004:
URL: https://github.com/apache/ranger/pull/1004#discussion_r3401239809


##########
dev-support/ranger-docker/scripts/kms/ranger-kms.sh:
##########
@@ -37,6 +37,7 @@ then
     if [ "${KERBEROS_ENABLED}" == "true" ]
     then
       cp ${RANGER_SCRIPTS}/core-site.xml 
${RANGER_HOME}/kms/ews/webapp/WEB-INF/classes/conf/core-site.xml
+      cp ${RANGER_SCRIPTS}/kms-site.xml 
${RANGER_HOME}/kms/ews/webapp/WEB-INF/classes/conf/kms-site.xml

Review Comment:
   @kumaab , thanks for your review !
   
   Abhishek, Is it okay to merge this PR right now as it is blocking many 
testing that I do in docker. This PR contains fixes to make KMS run in Kerberos 
enabled env. There are some other functional test related work going on that is 
blocked as KMS is not working.
   
   I can create a new JIRA and can work to refactor KMS docker bootstrap to use 
runtime XML config separately.
   
   What's your thought on this ?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to