vyommani commented on code in PR #1004:
URL: https://github.com/apache/ranger/pull/1004#discussion_r3413069170
##########
distro/src/main/assembly/kms.xml:
##########
@@ -201,6 +201,7 @@
<include>com.fasterxml.jackson.core:jackson-core:jar:${fasterxml.jackson.version}</include>
<include>com.fasterxml.jackson.core:jackson-databind:jar:${fasterxml.jackson.databind.version}</include>
<include>org.javassist:javassist</include>
+
<include>org.apache.ranger:ranger-common-utils</include>
Review Comment:
The fix makes sense moving ranger-common-utils to WEB-INF/lib eliminates
the dual classloader loading of Jackson. A couple of things worth verifying:
1--> Are there any other jars remaining in the ews/lib moduleSet that are
also present in WEB-INF/lib? If so, we'd have the same loader constraint risk
for those classes once WEB-INF/lib/* is added to the JVM classpath (see comment
on kms/scripts/ranger-kms).
2--> Is there anything in the KMS startup lifecycle that runs before the
webapp classloader is active and depends on ranger-common-utils? Since it's no
longer in ews/lib, it won't be available at the JVM level until Tomcat loads
the webapp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
