vyommani commented on code in PR #1004:
URL: https://github.com/apache/ranger/pull/1004#discussion_r3413047545
##########
kms/scripts/ranger-kms:
##########
@@ -112,7 +112,7 @@ fi
KMS_CONF_DIR=${RANGER_KMS_EWS_DIR}/webapp/WEB-INF/classes/conf
SERVER_NAME=rangerkms
-cp="-cp
${RANGER_KMS_EWS_CONF_DIR}:${RANGER_KMS_EWS_DIR}/lib/*:${JAVA_HOME}/lib/*:${RANGER_HADOOP_CONF_DIR}/*:$CLASSPATH"
+cp="-cp
${RANGER_KMS_EWS_CONF_DIR}:${RANGER_KMS_EWS_DIR}/lib/*:${RANGER_KMS_EWS_DIR}/webapp/WEB-INF/lib/*:${JAVA_HOME}/lib/*:${RANGER_HADOOP_CONF_DIR}/*:$CLASSPATH"
Review Comment:
Adding WEB-INF/lib/* to the JVM-level classpath fixes the immediate issue
but potentially reintroduces the same classloader duplication pattern for any
jar that exists in both ews/lib/* and WEB-INF/lib/*. Could you check if there's
any overlap between the two directories in the assembled KMS package? Ideally
the two classpaths should be disjoint — otherwise we may just be shifting the
LinkageError to a different class down the line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
