----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51427/#review146788 -----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java (line 279) <https://reviews.apache.org/r/51427/#comment213463> If this sort cannot be avoided, then is it necessary to also have a periodic reordering of all evaluators (triggered from BasePlugin)? Please review. agents-common/src/main/java/org/apache/ranger/plugin/util/RangerResourceTrie.java (line 76) <https://reviews.apache.org/r/51427/#comment213457> For efficiency, RangerAbstractResourceMatcher for this evaluator (indexed by resourceName) may be looked up here to see if isMatchAny is true. If so, addWildcardPolicy() can be called and the next for loop can be skipped. agents-common/src/main/java/org/apache/ranger/plugin/util/RangerResourceTrie.java (line 130) <https://reviews.apache.org/r/51427/#comment213459> It will be useful to get and print maximum depth of the Trie tree for debugging/worst case performance estimation purpose. agents-common/src/main/java/org/apache/ranger/plugin/util/RangerResourceTrie.java (line 171) <https://reviews.apache.org/r/51427/#comment213460> Consider printing max-depth of the Trie tree here. - Abhay Kulkarni On Aug. 25, 2016, 10:49 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51427/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2016, 10:49 a.m.) > > > Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Abhay > Kulkarni, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja > Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-1161 > https://issues.apache.org/jira/browse/RANGER-1161 > > > Repository: ranger > > > Description > ------- > > Updated policy engine to reduce the number of policies evaluated for an > access request by using RangerResourceTrie. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java > 90da6af > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineOptions.java > 805f5a5 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java > 40fe8b6 > > agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java > 760fab7 > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerResourceTrie.java > PRE-CREATION > > ranger-tools/src/main/java/org/apache/ranger/policyengine/CommandLineParser.java > d6c028f > > ranger-tools/src/main/java/org/apache/ranger/policyengine/PerfTestEngine.java > cf83260 > > ranger-tools/src/main/java/org/apache/ranger/policyengine/PerfTestOptions.java > 321ee69 > > ranger-tools/src/main/java/org/apache/ranger/policyengine/RangerPolicyenginePerfTester.java > 03ea6d0 > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > bafd3f8 > > Diff: https://reviews.apache.org/r/51427/diff/ > > > Testing > ------- > > Verified that all policy engine units pass successfully. > > > Thanks, > > Madhan Neethiraj > >
