> On Aug. 25, 2016, 4:12 p.m., Abhay Kulkarni wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java, > > line 281 > > <https://reviews.apache.org/r/51427/diff/1/?file=1485745#file1485745line281> > > > > If this sort cannot be avoided, then is it necessary to also have a > > periodic reordering of all evaluators (triggered from BasePlugin)? Please > > review.
Sorting here is necessary, as the returned list will be the intersection of policies for all resource-levels. Periodic reordering of all the nodes in the Trie may not buy much, it might just add complexity. - Madhan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51427/#review146788 ----------------------------------------------------------- On Aug. 25, 2016, 5:39 p.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51427/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2016, 5:39 p.m.) > > > Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Abhay > Kulkarni, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja > Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-1161 > https://issues.apache.org/jira/browse/RANGER-1161 > > > Repository: ranger > > > Description > ------- > > Updated policy engine to reduce the number of policies evaluated for an > access request by using RangerResourceTrie. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java > 90da6af > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineOptions.java > 805f5a5 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java > 40fe8b6 > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java > f954ccf > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerPolicyEvaluator.java > a7dc833 > > agents-common/src/main/java/org/apache/ranger/plugin/policyresourcematcher/RangerDefaultPolicyResourceMatcher.java > 733049f > > agents-common/src/main/java/org/apache/ranger/plugin/policyresourcematcher/RangerPolicyResourceMatcher.java > 54b9586 > > agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerAbstractResourceMatcher.java > 329b8e8 > > agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerResourceMatcher.java > c1b3404 > > agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java > 760fab7 > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerResourceTrie.java > PRE-CREATION > > ranger-tools/src/main/java/org/apache/ranger/policyengine/CommandLineParser.java > d6c028f > > ranger-tools/src/main/java/org/apache/ranger/policyengine/PerfTestEngine.java > cf83260 > > ranger-tools/src/main/java/org/apache/ranger/policyengine/PerfTestOptions.java > 321ee69 > > ranger-tools/src/main/java/org/apache/ranger/policyengine/RangerPolicyenginePerfTester.java > 03ea6d0 > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > bafd3f8 > > Diff: https://reviews.apache.org/r/51427/diff/ > > > Testing > ------- > > Verified that all policy engine units pass successfully. > > > Thanks, > > Madhan Neethiraj > >
