----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51427/#review146894 -----------------------------------------------------------
Fix it, then Ship it! agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java (line 247) <https://reviews.apache.org/r/51427/#comment213682> This flag and subsequent code to find shorter of two non-empty lists may not be needed, because, with two non-empty lists a and b, computing intersection of a and b will be cost the same. That is, a.containAll(b) will cost the same as b.containAll(a). Cost will be proportional to [size(a) * size(b)]. Please review. agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java (line 735) <https://reviews.apache.org/r/51427/#comment213685> Please consider reordering policyEvaluators (and dataMaskPolicyEvaluators and rowFilterPolicyEvaluators) only if their corresponding Trie trees do not exist. - Abhay Kulkarni On Aug. 26, 2016, midnight, Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51427/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2016, midnight) > > > Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Abhay > Kulkarni, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja > Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-1161 > https://issues.apache.org/jira/browse/RANGER-1161 > > > Repository: ranger > > > Description > ------- > > Updated policy engine to reduce the number of policies evaluated for an > access request by using RangerResourceTrie. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java > 90da6af > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineOptions.java > 805f5a5 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java > 40fe8b6 > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java > f954ccf > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerPolicyEvaluator.java > a7dc833 > > agents-common/src/main/java/org/apache/ranger/plugin/policyresourcematcher/RangerDefaultPolicyResourceMatcher.java > 733049f > > agents-common/src/main/java/org/apache/ranger/plugin/policyresourcematcher/RangerPolicyResourceMatcher.java > 54b9586 > > agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerAbstractResourceMatcher.java > 329b8e8 > > agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerResourceMatcher.java > c1b3404 > > agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java > 760fab7 > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerResourceTrie.java > PRE-CREATION > > ranger-tools/src/main/java/org/apache/ranger/policyengine/CommandLineParser.java > d6c028f > > ranger-tools/src/main/java/org/apache/ranger/policyengine/PerfTestEngine.java > cf83260 > > ranger-tools/src/main/java/org/apache/ranger/policyengine/PerfTestOptions.java > 321ee69 > > ranger-tools/src/main/java/org/apache/ranger/policyengine/RangerPolicyenginePerfTester.java > 03ea6d0 > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > bafd3f8 > > Diff: https://reviews.apache.org/r/51427/diff/ > > > Testing > ------- > > Verified that all policy engine units pass successfully. > > > Thanks, > > Madhan Neethiraj > >
