runzhiwang commented on a change in pull request #185:
URL: https://github.com/apache/incubator-ratis/pull/185#discussion_r481853565
##########
File path:
ratis-grpc/src/main/java/org/apache/ratis/grpc/server/GrpcLogAppender.java
##########
@@ -166,24 +169,26 @@ protected boolean shouldSendRequest() {
return appendLogRequestObserver == null || super.shouldSendRequest();
}
- /** @return true iff not received first response or queue is full. */
- private boolean shouldWait() {
+ /**
+ * @return true iff not received first response or queue is full.
+ */
+ private boolean haveTooManyPendingRequests() {
final int size = pendingRequests.logRequestsSize();
if (size == 0) {
return false;
}
return !firstResponseReceived || size >= maxPendingRequestsNum;
}
- private void appendLog() throws IOException {
+ private void appendLog(boolean excludeLogEntries) throws IOException {
Review comment:
Can we rename excludeLogEntries to heartbeat ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
