lokeshj1703 commented on a change in pull request #185:
URL: https://github.com/apache/incubator-ratis/pull/185#discussion_r484376756
##########
File path:
ratis-grpc/src/main/java/org/apache/ratis/grpc/server/GrpcLogAppender.java
##########
@@ -101,41 +101,44 @@ private synchronized void
resetClient(AppendEntriesRequest request) {
@Override
protected void runAppenderImpl() throws IOException {
- boolean shouldAppendLog;
+ boolean installSnapshotRequired;
Review comment:
I agree, it would be a good idea to do it in a separate PR. There are
many changes in GrpcLogAppender which would be good to have in LogAppender.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
