szetszwo commented on a change in pull request #364:
URL: https://github.com/apache/incubator-ratis/pull/364#discussion_r546192544
##########
File path: ratis-proto/src/main/proto/Raft.proto
##########
@@ -280,6 +280,19 @@ message WatchRequestTypeProto {
ReplicationLevel replication = 2;
}
+message RoutePairProto {
+ RaftPeerProto from = 1;
+ RaftPeerProto to = 2;
+}
+
+message DataStreamRouteTableProto {
+ repeated RoutePairProto routeTable = 1;
+}
Review comment:
Let's call them RouteProto and RoutingTableProto. It may be useful
outside DataStream in the future.
Let's use RaftPeerId instead of RaftPeerProto. It may be a good time to
create RaftPeerIdProto which is currently missing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
