szetszwo commented on a change in pull request #364:
URL: https://github.com/apache/incubator-ratis/pull/364#discussion_r546194092
##########
File path:
ratis-netty/src/main/java/org/apache/ratis/netty/server/DataStreamManagement.java
##########
@@ -231,23 +232,48 @@ StreamInfo remove(Key key) {
return f;
}
+
+ private IdentityHashMap<RaftPeer, RaftPeer> getRouteTable(RaftClientRequest
request)
Review comment:
Let's create a org.apache.ratis.protocol.RoutingTable interface/class in
ratis-common.
```
interface RoutingTable {
List<RaftPeerId> getSuccessors(RaftPeerId peer);
}
```
I think we should use RaftPeerId since the RaftPeer can be looked up locally.
BTW, why using IdentityHashMap but not just a Map in the implementation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
