szetszwo commented on a change in pull request #364:
URL: https://github.com/apache/incubator-ratis/pull/364#discussion_r546216876
##########
File path:
ratis-netty/src/main/java/org/apache/ratis/netty/server/DataStreamManagement.java
##########
@@ -231,23 +232,48 @@ StreamInfo remove(Key key) {
return f;
}
+
+ private IdentityHashMap<RaftPeer, RaftPeer> getRouteTable(RaftClientRequest
request)
Review comment:
IdentityHashMap may have unexpected behaviour since it uses == but not
equals(..). Let's use
```
Map<RaftPeerId, List<RaftPeerId>>
```
Or, we may use guava Multimap
https://guava.dev/releases/19.0/api/docs/com/google/common/collect/Multimap.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
