----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6240/#review9971 -----------------------------------------------------------
Patch works well . We dont have alert in rave and most of the validation are done by required attribute. HTML5 have required="required" for textarea also. Can we try using that? Thats better for mobile versions also. - Raminder Singh On July 31, 2012, 12:05 p.m., Daniel Gornstein wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6240/ > ----------------------------------------------------------- > > (Updated July 31, 2012, 12:05 p.m.) > > > Review request for rave. > > > Description > ------- > > This patch does not allow empty comments to be posted on a widget in the > store. If you try to post an empty comment an alert box pops up asking you to > please enter text into the comment field. > > Also added a line which clears out the comment field after posting a comment. > Before, the same text you just submitted was still populated in the comment > box. > > > Diffs > ----- > > trunk/rave-portal-resources/src/main/webapp/static/script/rave_store.js > 1367061 > > Diff: https://reviews.apache.org/r/6240/diff/ > > > Testing > ------- > > > Thanks, > > Daniel Gornstein > >
