> On Jan. 7, 2013, 8:16 p.m., Raminder Singh wrote: > >
I found some minor issue like missing apache license, personal signatures (remove Idea @author tag etc). Code looks good to me but i am not able to test is using ActivityStreams gadget because org.apache.rave.opensocial.service.impl.MultiFormatActivityService need to be implemented. There is an other issue with BLOB not supported by H2. You will see lot of Warn messages on console while starting cargo. Jason can you also provide instructions to test this and add unit test for the code. - Raminder ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8861/#review15120 ----------------------------------------------------------- On Jan. 7, 2013, 3:05 p.m., Jason Letourneau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8861/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2013, 3:05 p.m.) > > > Review request for rave. > > > Description > ------- > > RAVE-865 - Add Activity Streams (activitystrea.ms) classes (model, > repository, core, and JPA) to Rave components > > > Diffs > ----- > > /trunk/rave-components/rave-core/pom.xml 1429806 > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/model/ActivityStreamObject.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/model/impl/ActivityEntryEntity.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/model/impl/ActivityObjectEntity.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/model/impl/MediaLinkEntity.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/repository/ActivityRepository.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/serialization/ActivityEntryEntityDeserializer.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/serialization/ActivityObjectEntityDeserializer.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/serialization/ActivityStreamParser.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityEntryComponent.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectComponent.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectName.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectType.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectVerb.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/MediaLinkComponent.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/OpenSocialActivityExtensions.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/util/ModelUtil.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/resources/org/apache/rave/core-applicationContext.xml > 1429806 > > /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/activities/model/impl/JpaActivityEntryEntity.java > PRE-CREATION > > /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/activities/model/impl/JpaActivityObjectEntity.java > PRE-CREATION > > /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/activities/model/impl/JpaMediaLinkEntity.java > PRE-CREATION > > /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/activities/repository/JpaActivityEntryRepository.java > PRE-CREATION > > /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/activities/repository/util/JpaUtil.java > PRE-CREATION > > /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/activities/serialization/JpaActivityStreamParser.java > PRE-CREATION > /trunk/rave-components/rave-jpa/src/main/resources/META-INF/persistence.xml > 1429806 > > /trunk/rave-components/rave-jpa/src/main/resources/org/apache/rave/persistence-applicationContext.xml > 1429806 > > Diff: https://reviews.apache.org/r/8861/diff/ > > > Testing > ------- > > built and deployed on Mac OSX Mountain Lion development environment. Code > ported from proof of concept activity stream project using rave-shindig. > > > Thanks, > > Jason Letourneau > >
