----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8861/#review15583 -----------------------------------------------------------
Sorry, I just saw a few more things. /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/activities/repository/util/JpaUtil.java <https://reviews.apache.org/r/8861/#comment33667> Rave already contains a JpaUtil with a getSingleResult method. /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/activities/repository/util/JpaUtil.java <https://reviews.apache.org/r/8861/#comment33668> I am a little confused on how it gets in the way... can you elaborate? /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaActivityEntryEntity.java <https://reviews.apache.org/r/8861/#comment33664> This is a gson annotation. Since we aren't using GSON anywhere else, I am not sure it makes sense in this context to add these annotations - Matt Franklin On Jan. 22, 2013, 8:39 p.m., Jason Letourneau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8861/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2013, 8:39 p.m.) > > > Review request for rave. > > > Description > ------- > > RAVE-865 - Add Activity Streams (activitystrea.ms) classes (model, > repository, core, and JPA) to Rave components > > > Diffs > ----- > > /trunk/rave-components/rave-core/pom.xml 1437003 > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/serialization/ActivityEntryDeserializer.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/serialization/ActivityObjectDeserializer.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/serialization/ActivityStreamParser.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityEntryComponent.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectComponent.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectName.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectType.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectVerb.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/MediaLinkComponent.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/OpenSocialActivityExtensions.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/ActivityStreamObject.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/impl/ActivityEntryImpl.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/impl/ActivityObjectImpl.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/impl/MediaLinkImpl.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/ActivityRepository.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/util/ModelUtil.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/resources/org/apache/rave/core-applicationContext.xml > 1437003 > > /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/model/impl/ActivityEntryTest.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/model/impl/ActivityObjectTest.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/model/impl/MediaLinkTest.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/serialization/ActivityEntryDeserializerTest.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/serialization/ActivityObjectDeserializerTest.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/serialization/ActivityStreamParserTest.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/util/ModelUtilTest.java > PRE-CREATION > > /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/activities/repository/util/JpaUtil.java > PRE-CREATION > > /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/activities/serialization/JpaActivityStreamParser.java > PRE-CREATION > > /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaActivityEntryEntity.java > PRE-CREATION > > /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaActivityObjectEntity.java > PRE-CREATION > > /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaMediaLinkEntity.java > PRE-CREATION > > /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/repository/impl/JpaActivityEntryRepository.java > PRE-CREATION > /trunk/rave-components/rave-jpa/src/main/resources/META-INF/persistence.xml > 1437003 > > /trunk/rave-components/rave-jpa/src/main/resources/org/apache/rave/persistence-applicationContext.xml > 1437003 > > /trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/model/impl/JpaActivityEntryEntityTest.java > PRE-CREATION > > /trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/model/impl/JpaActivityObjectEntityTest.java > PRE-CREATION > > /trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/model/impl/JpaMediaLinkEntityTest.java > PRE-CREATION > > /trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/repository/JpaActivityEntryRepositoryTest.java > PRE-CREATION > > /trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/repository/util/JpaUtilTest.java > PRE-CREATION > > /trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/serialization/JpaActivityStreamParserTest.java > PRE-CREATION > /trunk/rave-components/rave-mongodb/pom.xml 1437003 > > Diff: https://reviews.apache.org/r/8861/diff/ > > > Testing > ------- > > built and deployed on Mac OSX Mountain Lion development environment. Code > ported from proof of concept activity stream project using rave-shindig. > > > Thanks, > > Jason Letourneau > >
