----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8861/#review15572 -----------------------------------------------------------
Thanks for the patch and continuing to tweak it for us. A couple of comments and a question: 1) IMO, the convention of keeping model interfaces in org.apache.rave.portal.model should be kept for the activity model interfaces 2) Same as above for the repository in the repository package 3) The impls should keep the existing convention of ending in Impl instead of Entity 4) There is a lot of serialization/deserialization machinery, but I didn't see an endpoint as part of the patch. Where is this used? - Matt Franklin On Jan. 22, 2013, 3:51 p.m., Jason Letourneau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8861/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2013, 3:51 p.m.) > > > Review request for rave. > > > Description > ------- > > RAVE-865 - Add Activity Streams (activitystrea.ms) classes (model, > repository, core, and JPA) to Rave components > > > Diffs > ----- > > /trunk/rave-components/rave-core/pom.xml 1437003 > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/serialization/ActivityEntryEntityDeserializer.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/serialization/ActivityObjectEntityDeserializer.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/serialization/ActivityStreamParser.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityEntryComponent.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectComponent.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectName.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectType.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectVerb.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/MediaLinkComponent.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/OpenSocialActivityExtensions.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/ActivityStreamObject.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/impl/ActivityEntryEntity.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/impl/ActivityObjectEntity.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/impl/MediaLinkEntity.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/ActivityRepository.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/util/ModelUtil.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/resources/org/apache/rave/core-applicationContext.xml > 1437003 > > /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/model/impl/ActivityEntryEntityTest.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/model/impl/ActivityObjectEntityTest.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/model/impl/MediaLinkEntityTest.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/serialization/ActivityEntryEntityDeserializerTest.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/serialization/ActivityObjectEntityDeserializerTest.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/serialization/ActivityStreamParserTest.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/util/ModelUtilTest.java > PRE-CREATION > > /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/activities/repository/util/JpaUtil.java > PRE-CREATION > > /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/activities/serialization/JpaActivityStreamParser.java > PRE-CREATION > > /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaActivityEntryEntity.java > PRE-CREATION > > /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaActivityObjectEntity.java > PRE-CREATION > > /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaMediaLinkEntity.java > PRE-CREATION > > /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/repository/impl/JpaActivityEntryRepository.java > PRE-CREATION > /trunk/rave-components/rave-jpa/src/main/resources/META-INF/persistence.xml > 1437003 > > /trunk/rave-components/rave-jpa/src/main/resources/org/apache/rave/persistence-applicationContext.xml > 1437003 > > /trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/model/impl/JpaActivityEntryEntityTest.java > PRE-CREATION > > /trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/model/impl/JpaActivityObjectEntityTest.java > PRE-CREATION > > /trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/model/impl/JpaMediaLinkEntityTest.java > PRE-CREATION > > /trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/repository/JpaActivityEntryRepositoryTest.java > PRE-CREATION > > /trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/repository/util/JpaUtilTest.java > PRE-CREATION > > /trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/serialization/JpaActivityStreamParserTest.java > PRE-CREATION > /trunk/rave-components/rave-mongodb/pom.xml 1437003 > > Diff: https://reviews.apache.org/r/8861/diff/ > > > Testing > ------- > > built and deployed on Mac OSX Mountain Lion development environment. Code > ported from proof of concept activity stream project using rave-shindig. > > > Thanks, > > Jason Letourneau > >
