----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8861/#review15751 -----------------------------------------------------------
Thanks for working through these issues and your patience /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/ActivityStreamsRepository.java <https://reviews.apache.org/r/8861/#comment33906> This interface should just return or accept the ActivityStreamsXxx Interface /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/repository/impl/JpaActivityStreamsRepository.java <https://reviews.apache.org/r/8861/#comment33907> What happens if this is an instance of ActivityStreamsEntryImpl and not JpaActivityStreamsEntry? - Matt Franklin On Jan. 25, 2013, 8:31 p.m., Jason Letourneau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8861/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2013, 8:31 p.m.) > > > Review request for rave. > > > Description > ------- > > RAVE-865 - Add Activity Streams (activitystrea.ms) classes (model, > repository, core, and JPA) to Rave components > > > Diffs > ----- > > > /trunk/rave-components/rave-commons/src/main/java/org/apache/rave/persistence/jpa/util/JpaUtil.java > 1437003 > /trunk/rave-components/rave-core/pom.xml 1437003 > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityEntryComponent.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectComponent.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/MediaLinkComponent.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/ActivityStreamsObject.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/impl/ActivityStreamsEntryImpl.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/impl/ActivityStreamsMediaLinkImpl.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/impl/ActivityStreamsObjectImpl.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/ActivityStreamsRepository.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/util/ModelUtil.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/main/resources/org/apache/rave/core-applicationContext.xml > 1437003 > > /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/model/impl/ActivityStreamsEntryTest.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/model/impl/ActivityStreamsMediaLinkTest.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/model/impl/ActivityStreamsObjectTest.java > PRE-CREATION > > /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/util/ModelUtilTest.java > PRE-CREATION > > /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaActivityStreamsEntry.java > PRE-CREATION > > /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaActivityStreamsMediaLink.java > PRE-CREATION > > /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaActivityStreamsObject.java > PRE-CREATION > > /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/repository/impl/JpaActivityStreamsRepository.java > PRE-CREATION > /trunk/rave-components/rave-jpa/src/main/resources/META-INF/persistence.xml > 1437003 > > /trunk/rave-components/rave-jpa/src/main/resources/org/apache/rave/persistence-applicationContext.xml > 1437003 > > /trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/model/impl/JpaActivityStreamsEntryTest.java > PRE-CREATION > > /trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/model/impl/JpaActivityStreamsMediaLinkTest.java > PRE-CREATION > > /trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/model/impl/JpaActivityStreamsObjectTest.java > PRE-CREATION > > /trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/repository/JpaActivityEntryRepositoryTest.java > PRE-CREATION > /trunk/rave-components/rave-mongodb/pom.xml 1437003 > > /trunk/rave-providers/rave-opensocial-provider/rave-opensocial-core/src/main/java/org/apache/rave/opensocial/service/impl/DefaultActivityStreamsService.java > PRE-CREATION > > /trunk/rave-providers/rave-opensocial-provider/rave-opensocial-core/src/main/java/org/apache/rave/opensocial/service/impl/DefaultPersonService.java > 1437003 > > /trunk/rave-providers/rave-opensocial-provider/rave-opensocial-core/src/main/java/org/apache/rave/util/ActivityConversionUtil.java > PRE-CREATION > > /trunk/rave-providers/rave-opensocial-provider/rave-opensocial-core/src/test/java/org/apache/rave/opensocial/service/DefaultActivityStreamsServiceTest.java > PRE-CREATION > > /trunk/rave-providers/rave-opensocial-provider/rave-opensocial-core/src/test/java/org/apache/rave/opensocial/util/ActivityConversionUtilTest.java > PRE-CREATION > > /trunk/rave-providers/rave-opensocial-provider/rave-opensocial-core/src/test/resources/rave-shindig-test-applicationContext.xml > 1437003 > > Diff: https://reviews.apache.org/r/8861/diff/ > > > Testing > ------- > > built and deployed on Mac OSX Mountain Lion development environment. Code > ported from proof of concept activity stream project using rave-shindig. > > > Thanks, > > Jason Letourneau > >
