[
https://issues.apache.org/jira/browse/RAVE-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14295658#comment-14295658
]
Matt Franklin commented on RAVE-1293:
-------------------------------------
Comments on patch:
|File|Line |Comment
|DefaultScriptManager| 59 |If the URL does not exist, the system simply
silently ignores this fact and continues to render. Is this the intended
behavior?|
|DefaultScriptManager| 76 |This creates a ScriptHolder with a script body
and a URL. in getScriptBlocks, it seems like these are mutually exlusive
cases, is this intended to just allow the caller to optionally use URL or
script? If so, wouldn't a better pattern be to define two methods?|
|DefaultScriptManager| 96 |IMO, this is better encapsulated in a utility
class|
|DefaultScriptManager| 99 |This comment is not valid in this case,
correct?|
|DefaultScriptManager| 109 |Use a logger rather than e.printStackTrace()|
|OpenSocialEnvironment| 49 |Line 48 defines the URL template separately.
This constant should use that template.|
|rave_openajax_hub.js| 25 |It is unclear to me why the former construct
does not work for this use case any longer|
|rave_openajax_hub.js| 30 |What might make more sense here is to pull the
exports = block out into a separate function. You can then require osapi, if
there is an error, require the OOTB OpenAjax Hub in the error function or if
OSAPI doesn't include it|
|rave_opensocial.js |- | Spacing issues. Try to keep formatting changes
separate.|
|ScriptHolder.java |- | Add license header|
|ScriptHolder.java |- | Document usage and function|
|ScriptManager.java |58| Document usage and function|
> Rave crashes when shindig is not available
> ------------------------------------------
>
> Key: RAVE-1293
> URL: https://issues.apache.org/jira/browse/RAVE-1293
> Project: Rave
> Issue Type: Bug
> Components: rave-opensocial-provider
> Affects Versions: 0.23
> Reporter: Gonzalo Aguilar
> Fix For: 0.24
>
> Attachments: level2-shindig-prefix.patch
>
>
> Rave fails when shindig is not available when trying to get metadata info for
> a widget. This patch returns an empty metadata when it's not available so
> Rave can render an empty widget.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
