Hi, Thanks for that, looking there, a see a couple of minor issues: - A number of .ccp and .h are files are missing headers. It seems a little random which files have ASF headers and which don’t. - There is some 3rd party code in the repo for instance big_endian.cpp/.h and code in src/thread/disruptor. There have permissive licenses so there’s no issues there. > I will check each files, and add ASF headers to all of them, thanks.
Given the above are you 100% sure all files have been developed in the project and that none of the 20 or 30 files with missing header have came from elsewhere? > big_endian files are copied from Chromium and Disruptor files in >src/thread/disruptor are copied from github, these codes have permissive >licenses. Has anyone contributed in the past to the code base other than yourself? > All functions are coded and tested by myself. ------------------------------------------------------------------发件人：Justin Mclean <[email protected]>发送时间：2018年1月5日(星期五) 12:15收件人：dev <[email protected]>; 王启伟(孝孺) <[email protected]>主 题：Re: [DISCUSS] How to handle Ip-clearance for apache rocketmq community projects Hi, > Thanks for your time, Let me give some explanation for your questions. >Rocketmq-cpp client for both windows and linux are located at: >https://github.com/apache/rocketmq-externals/tree/master/rocketmq-cpp Thanks for that, looking there, a see a couple of minor issues: - A number of .ccp and .h are files are missing headers. It seems a little random which files have ASF headers and which don’t. - There is some 3rd party code in the repo for instance big_endian.cpp/.h and code in src/thread/disruptor. There have permissive licenses so there’s no issues there. Given the above are you 100% sure all files have been developed in the project and that none of the 20 or 30 files with missing header have came from elsewhere? > I had signed ICLA before, only me contributes this rocketmq-cpp client >currently, looking forward to new volunteers. Has anyone contributed in the past to the code base other than yourself? Thanks, Justin
