Jason918 commented on a change in pull request #3382:
URL: https://github.com/apache/rocketmq/pull/3382#discussion_r724662086
##########
File path: store/src/main/java/org/apache/rocketmq/store/MappedFile.java
##########
@@ -288,6 +289,7 @@ public int flush(final int flushLeastPages) {
}
} catch (Throwable e) {
log.error("Error occurred when force data to disk.", e);
+ this.flushError = true;
Review comment:
The problem is that if there's some kind of error which happens
occasionally and flush error will be retried success in the next round. Is it
too much that just make the whole broker not writable for one occasionally
write error?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
