Jason918 commented on a change in pull request #3382:
URL: https://github.com/apache/rocketmq/pull/3382#discussion_r753893906
##########
File path: store/src/main/java/org/apache/rocketmq/store/MappedFile.java
##########
@@ -288,6 +289,7 @@ public int flush(final int flushLeastPages) {
}
} catch (Throwable e) {
log.error("Error occurred when force data to disk.", e);
+ this.flushError = true;
Review comment:
It's ok for some users that data is written on the disk eventually.
Changing this default behavior have too much compact on the compatibility.
IMHO, maybe adding an optional config to enable this fast failure feature on
disk error?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
