iamqq23ue commented on a change in pull request #3382:
URL: https://github.com/apache/rocketmq/pull/3382#discussion_r724670419
##########
File path: store/src/main/java/org/apache/rocketmq/store/MappedFileQueue.java
##########
@@ -442,6 +443,9 @@ public boolean flush(final int flushLeastPages) {
if (mappedFile != null) {
long tmpTimeStamp = mappedFile.getStoreTimestamp();
int offset = mappedFile.flush(flushLeastPages);
+ if (mappedFile.getflushError()) {
Review comment:
看太明白，您的意思是失败后不再执行接下来的代码吗？我改的时候想的是尽量少改动代码，解决眼前的问题哈。毕竟别人的想法未必和我一样，改动大了可能和别人冲突了。
这里涉及另一个bug了，master落后于slave的时候，master依然可以写入，只会有日志报错。不修改这部分的话，flushwhere改不改感觉意义不大。当然您如果还能进一步优化更好了。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
