odbozhou commented on code in PR #117:
URL: https://github.com/apache/rocketmq-connect/pull/117#discussion_r867663143
##########
connectors/rocketmq-replicator/src/main/java/org/apache/rocketmq/replicator/config/RmqConnectorConfig.java:
##########
@@ -25,7 +25,7 @@
import org.apache.rocketmq.replicator.strategy.TaskDivideStrategy;
public class RmqConnectorConfig {
-
+ @Deprecated
private int taskParallelism;
Review Comment:
Is it possible to delete this property directly?
##########
connectors/rocketmq-replicator/src/main/java/org/apache/rocketmq/replicator/config/RmqConnectorConfig.java:
##########
@@ -48,7 +48,7 @@ public class RmqConnectorConfig {
public RmqConnectorConfig() {
}
- public void validate(KeyValue config) {
+ public void init(KeyValue config) {
this.taskParallelism =
config.getInt(ConfigDefine.CONN_TASK_PARALLELISM, 1);
Review Comment:
Is it possible to delete this property directly?
##########
connectors/rocketmq-replicator/src/main/java/org/apache/rocketmq/replicator/config/TaskDivideConfig.java:
##########
@@ -28,6 +28,7 @@ public class TaskDivideConfig {
private int dataType;
+ @Deprecated
private int taskParallelism;
Review Comment:
Is it possible to delete this property directly?
##########
connectors/rocketmq-replicator/src/main/java/org/apache/rocketmq/replicator/RmqMetaReplicator.java:
##########
@@ -139,7 +153,7 @@ public List<KeyValue> taskConfigs() {
e.printStackTrace();
}
- return Utils.groupPartitions(new ArrayList<>(this.knownGroups),
this.replicatorConfig.getTaskParallelism(), replicatorConfig);
+ return Utils.groupPartitions(new ArrayList<>(this.knownGroups),
this.replicatorConfig.getTaskParallelism(), replicatorConfig, maxTasks);
Review Comment:
Is it possible to delete taskParallelism directly?
##########
connectors/rocketmq-replicator/src/main/java/org/apache/rocketmq/replicator/strategy/DivideTaskByQueue.java:
##########
@@ -31,10 +31,11 @@
public class DivideTaskByQueue extends TaskDivideStrategy {
- @Override public List<KeyValue> divide(Map<String, Set<TaskTopicInfo>>
topicRouteMap, TaskDivideConfig tdc) {
+ @Override
+ public List<KeyValue> divide(Map<String, Set<TaskTopicInfo>>
topicRouteMap, TaskDivideConfig tdc, int maxTasks) {
List<KeyValue> config = new ArrayList<KeyValue>();
- int parallelism = tdc.getTaskParallelism();
+ int parallelism = Math.min(tdc.getTaskParallelism(), maxTasks);
Review Comment:
Is it possible to delete taskParallelism directly?
##########
connectors/rocketmq-replicator/src/main/java/org/apache/rocketmq/replicator/strategy/DivideTaskByConsistentHash.java:
##########
@@ -32,10 +32,11 @@
import org.apache.rocketmq.replicator.config.TaskTopicInfo;
public class DivideTaskByConsistentHash extends TaskDivideStrategy {
- @Override public List<KeyValue> divide(Map<String, Set<TaskTopicInfo>>
topicMap, TaskDivideConfig tdc) {
+ @Override
+ public List<KeyValue> divide(Map<String, Set<TaskTopicInfo>> topicMap,
TaskDivideConfig tdc, int maxTasks) {
List<KeyValue> config = new ArrayList<>();
- int parallelism = tdc.getTaskParallelism();
+ int parallelism = Math.min(tdc.getTaskParallelism(), maxTasks);
Review Comment:
Is it possible to delete taskParallelism directly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
