Slideee commented on code in PR #117:
URL: https://github.com/apache/rocketmq-connect/pull/117#discussion_r867674521
##########
connectors/rocketmq-replicator/src/main/java/org/apache/rocketmq/replicator/strategy/DivideTaskByConsistentHash.java:
##########
@@ -32,10 +32,11 @@
import org.apache.rocketmq.replicator.config.TaskTopicInfo;
public class DivideTaskByConsistentHash extends TaskDivideStrategy {
- @Override public List<KeyValue> divide(Map<String, Set<TaskTopicInfo>>
topicMap, TaskDivideConfig tdc) {
+ @Override
+ public List<KeyValue> divide(Map<String, Set<TaskTopicInfo>> topicMap,
TaskDivideConfig tdc, int maxTasks) {
List<KeyValue> config = new ArrayList<>();
- int parallelism = tdc.getTaskParallelism();
+ int parallelism = Math.min(tdc.getTaskParallelism(), maxTasks);
Review Comment:
> Is it possible to delete taskParallelism directly?
if divide by hash or divide by queue or divide by group，directly use the
maxTasks parameter to control the number of tasks?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
