iamqq23ue commented on code in PR #4306:
URL: https://github.com/apache/rocketmq/pull/4306#discussion_r873469046
##########
store/src/main/java/org/apache/rocketmq/store/MappedFile.java:
##########
@@ -295,13 +295,15 @@ public int flush(final int flushLeastPages) {
try {
//We only append data to fileChannel or mappedByteBuffer,
never both.
+ this.flushError = false;
if (writeBuffer != null || this.fileChannel.position() !=
0) {
this.fileChannel.force(false);
} else {
this.mappedByteBuffer.force();
}
} catch (Throwable e) {
log.error("Error occurred when force data to disk.", e);
+ this.flushError = true;
Review Comment:
@dongeforever Thank you for your review. What you said is also a good idea
to solve the problem of data loss.very concise.
But IMO, if "just do not change the flushed position", it may cause
"FLUSH_DISK_TIMEOUT" in every flush. when FLUSH_DISK_TIMEOUT，even if the
client resends, it may still be sent to the failed broker. Can it be optimized?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
