dongeforever commented on code in PR #4306:
URL: https://github.com/apache/rocketmq/pull/4306#discussion_r874466053
##########
store/src/main/java/org/apache/rocketmq/store/MappedFile.java:
##########
@@ -295,13 +295,15 @@ public int flush(final int flushLeastPages) {
try {
//We only append data to fileChannel or mappedByteBuffer,
never both.
+ this.flushError = false;
if (writeBuffer != null || this.fileChannel.position() !=
0) {
this.fileChannel.force(false);
} else {
this.mappedByteBuffer.force();
}
} catch (Throwable e) {
log.error("Error occurred when force data to disk.", e);
+ this.flushError = true;
Review Comment:
Use sync master mode in the financial scenario, the SEND_OK is returned
only when the data is replicated to slave broker successfully.
If the flush gets an error, it usually means the disk is broken, it is time
to switch the broker role.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
