iamqq23ue commented on code in PR #4306:
URL: https://github.com/apache/rocketmq/pull/4306#discussion_r874491894
##########
store/src/main/java/org/apache/rocketmq/store/MappedFile.java:
##########
@@ -295,13 +295,15 @@ public int flush(final int flushLeastPages) {
try {
//We only append data to fileChannel or mappedByteBuffer,
never both.
+ this.flushError = false;
if (writeBuffer != null || this.fileChannel.position() !=
0) {
this.fileChannel.force(false);
} else {
this.mappedByteBuffer.force();
}
} catch (Throwable e) {
log.error("Error occurred when force data to disk.", e);
+ this.flushError = true;
Review Comment:
@dongeforever When the storage fails, the delayed message cannot be
delivered to the target topic, and the delayoffset.json will be synchronized to
the slave normally, which will cause the slave to be unable to recover the
delayed message .
In addition, the slave is also asynchronous flush. Relying on multiple nodes
to ensure that data is not lost, kafka can also do it. The disadvantage of
kafka is that there is no synchronous flush
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
