Hi Justin, Many thanks for your kind help.
I updated the LICENSE file, the non ASF ALv2 licenses has been added to our LICENSE file, and I think the mentioned [3],[4],[5] and [9] have been resolved. I am not sure how to seperate LICENSE and NOTICE files for the source and binary packages, Do you mean we need add four files at top level of the source tree ? LICENSE and NOTICE for source release, while LICENSE-BIN and NOTICE-BIN for binary release. And what's difference between the four files? IMO, The binary of RocketMQ has 8 dependencies: netty, commons-cli, commons-lang, fastjson, javassist, jna, logback, slf4j, while the source has some extra test scope dependencies like junit, assertj, mockito, so are these the difference between LICENSE/NOTICE and LICENSE-BIN/NOTICE-BIN files? I would appreciate your help. Thanks, yukon On Sat, Feb 11, 2017 at 12:19 PM, Justin Mclean <[email protected]> wrote: > Hi, > > > Justin, you are right, I have polished the LICENSE and NOTICE files, > would > > you please check help us check it again at your convenience? > > > > [1]. https://github.com/apache/incubator-rocketmq/blob/master/LICENSE > > [2]. https://github.com/apache/incubator-rocketmq/blob/master/NOTICE < > https://github.com/apache/incubator-rocketmq/blob/master/NOTICE> > Better (for the binary) but I think it still needs a little work. As I > said before we need seperate LICENSE and NOTCE files for the source and > binary packages not one for both. See [1][2] for an explanation. > > The binary is also several missing licenses as as I mentioned in my review > RC2, these should be added to LICENSE. > > While not strictly required it probably a good idea to also add the non > ASF ALv2 licenses to LICENSE as they are misisng NOTICE files and thus it > may be unclear who the copyright owner is. > > From my RC2 review: > "The binary LICENSE and NOTICE will need some more work as it bundles a > number of things that are not from the ASF, having multiple license or are > Apache licensed. See [2] (notice that affects ours), [3] (not ASF apache > software), [4] (multiple licenses), [5] (multiple licenses), [6] (non > Apache license), [7] (non Apache license), [8] (notice file)., [9] (non > Apache license).” > > As far as I can see [3], [4], [5] and [9] haven’t been addressed, if you > are unsure on how to deal with them or the above isn’t clear please ask and > I’ll help. > > Thanks, > Justin > > 1. http://www.apache.org/dev/licensing-howto.html#binary < > http://www.apache.org/dev/licensing-howto.html#binary> > 2. http://www.apache.org/dev/licensing-howto.html#guiding-principle < > http://www.apache.org/dev/licensing-howto.html#guiding-principle> > 3. https://github.com/alibaba/fastjson <https://github.com/alibaba/ > fastjson> > 4. https://github.com/jboss-javassist/javassist/blob/master/License.html < > https://github.com/jboss-javassist/javassist/blob/master/License.html> > 5. https://github.com/java-native-access/jna <https://github.com/java- > native-access/jna> > 9. https://www.slf4j.org/license.html <https://www.slf4j.org/license.html>
